GH-48433: [C++] Use NDEBUG to fix linkage to abseil libraries #48418

WillAyd · 2025-12-09T17:28:34Z

Rationale for this change

When referencing production abseil libraries but using a debug build type, libarrow_flight ends up referencing private symbols from the libabsl_syncrhonization library. For a reproducer in CI of the issue, see https://github.com/apache/arrow/actions/runs/20072853100/job/57579472724?pr=48418

What changes are included in this PR?

NDEBUG is defined for CI builds so that the abseil desctructor that only appears in debug builds is not present in Arrow libraries

Are these changes tested?

Yes

Are there any user-facing changes?

No - this update is strictly to the CI jobs

GitHub Issue: [C++] libarrow_flight symbol issue with pre-packaged Abseil >= 20240722.0 #48433

github-actions · 2025-12-09T17:28:57Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

github-actions · 2025-12-11T03:23:48Z

⚠️ GitHub issue #48433 has been automatically assigned in GitHub to PR creator.

cpp/examples/arrow/rapidjson_row_converter.cc

raulcd · 2025-12-11T09:09:56Z

@github-actions crossbow -g cpp

github-actions · 2025-12-11T09:10:31Z

No such option: -g
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/20127795278

raulcd · 2025-12-11T09:26:29Z

@github-actions crossbow submit -g cpp

github-actions · 2025-12-11T09:29:04Z

Revision: ff49bc1

Submitted crossbow builds: ursacomputing/crossbow @ actions-77d4e90756

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

WillAyd · 2025-12-17T14:46:12Z

@github-actions crossbow submit -g cpp

github-actions · 2025-12-17T14:48:57Z

Revision: 585cc00

Submitted crossbow builds: ursacomputing/crossbow @ actions-367649e114

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

WillAyd · 2025-12-17T15:48:18Z

@github-actions crossbow submit -g cpp

github-actions · 2025-12-17T15:51:09Z

Revision: 179e249

Submitted crossbow builds: ursacomputing/crossbow @ actions-37ceee83fe

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

WillAyd · 2025-12-17T17:39:47Z

I don't believe any of the current failures are related. @pitrou any interest in merging this one before your C++20 PR?

pitrou · 2025-12-18T08:30:40Z

Can you point the PR description to the existing upstream issue(s)?

WillAyd · 2025-12-18T20:55:35Z

The majority of these changes were merged in via #48414, so this PR and issue are mostly obsolete.

The example code in this PR will still fail, but at this point I think its clearest for issue lineage to close this and start fresh with a dedicate issue for that

github-actions bot added the awaiting review Awaiting review label Dec 9, 2025

WillAyd force-pushed the debug-abseil-issue branch from 21d5eaa to 9e14a14 Compare December 9, 2025 17:37

WillAyd changed the title ~~Debug abseil version issue~~ GH-48433: [C++] Use NDEBUG to fix linkage to abseil libraries Dec 11, 2025

WillAyd force-pushed the debug-abseil-issue branch from 9e14a14 to ff49bc1 Compare December 11, 2025 03:26

WillAyd marked this pull request as ready for review December 11, 2025 03:26

WillAyd requested review from assignUser, jonkeane, kou and raulcd as code owners December 11, 2025 03:26

github-actions bot added the Component: C++ label Dec 11, 2025

WillAyd mentioned this pull request Dec 11, 2025

GH-36411: [C++][Python] Use meson-python for PyArrow build system #45854

Open

raulcd reviewed Dec 11, 2025

View reviewed changes

cpp/examples/arrow/rapidjson_row_converter.cc Outdated Show resolved Hide resolved

raulcd added the CI: Extra Run extra CI label Dec 11, 2025

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 11, 2025

github-actions bot added awaiting change review Awaiting change review and removed Component: C++ awaiting changes Awaiting changes labels Dec 12, 2025

WillAyd mentioned this pull request Dec 15, 2025

GH-45885: [C++] Require C++20 #48414

Merged

WillAyd force-pushed the debug-abseil-issue branch from 6644265 to 585cc00 Compare December 17, 2025 14:45

WillAyd requested a review from lidavidm as a code owner December 17, 2025 14:45

github-actions bot added Component: C++ Component: FlightRPC labels Dec 17, 2025

WillAyd mentioned this pull request Dec 17, 2025

GH-48570: [C++] Add Missing Fuzz Sources to Meson configuration #48571

Merged

Use @pitrou solution to abseil symbol visibility issue

179e249

WillAyd force-pushed the debug-abseil-issue branch from 585cc00 to 179e249 Compare December 17, 2025 15:36

WillAyd closed this Dec 18, 2025

GH-48433: [C++] Use NDEBUG to fix linkage to abseil libraries #48418

GH-48433: [C++] Use NDEBUG to fix linkage to abseil libraries #48418

Uh oh!

Conversation

WillAyd commented Dec 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

Uh oh!

raulcd commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

raulcd commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

WillAyd commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

WillAyd commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

WillAyd commented Dec 17, 2025

Uh oh!

pitrou commented Dec 18, 2025

Uh oh!

WillAyd commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WillAyd commented Dec 9, 2025 •

edited by github-actions bot

Loading